Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fixes CI + other tests #76

Merged
merged 5 commits into from
Sep 23, 2024

Conversation

pbarbarant
Copy link
Collaborator

@pbarbarant pbarbarant commented Sep 19, 2024

Closes #75 and improves testing of both FUGWBarycenter and FUGWSparseBarycenter.

@pbarbarant pbarbarant changed the title Convert coarse plan to np [BUGFIX] Fixes CI + other tests Sep 19, 2024
@bthirion
Copy link
Collaborator

I'll review when the CI is green.

@pbarbarant
Copy link
Collaborator Author

I'll review when the CI is green.

Fixed.

Copy link
Collaborator

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

tests/mappings/test_sparse_barycenter.py Show resolved Hide resolved
@pbarbarant
Copy link
Collaborator Author

pbarbarant commented Sep 23, 2024

I also added extra assertions on the outputs of FUGW barycenters and tested the callbacks system on the sparse version.

Copy link
Collaborator

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx.

@pbarbarant pbarbarant merged commit dc8b819 into alexisthual:main Sep 23, 2024
7 checks passed
@pbarbarant pbarbarant deleted the fix/fix-barycenter-tests branch September 23, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fix tests
2 participants